Issue 266: Fix kernel bug #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 93.34% 93.40% +0.05%
==========================================
Files 45 45
Lines 451 455 +4
==========================================
+ Hits 421 425 +4
Misses 30 30 ☔ View full report in Codecov by Sentry. |
4 tasks
SamuelBrand1
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
This seems to work... I'm a bit uncomfortable that of you generate data e.g. y_t = missing then you have to pre-pend something like fill(missing, length(obs.pmf)) to then infer parameters.
But I think this kind of clunkiness is being improved by other PRs/issues.
Yes, in #268 hopefully (and if not does seem like its own issue beyond the bug fix) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
* add partial option * reverse partial if gate * add a test for new partial functionality * simplify LatentDelay * simplify LatentDelay --------- Co-authored-by: Samuel Brand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226 but adding a
partial = falseoption to the observation kernel generating funciton, adds tests for this, and uses this inLatentDelaymethod.Still not loving how this shifts complexity into the error model here. Holding this though as thinking about making a abstract type for observation error models where this could be offloaded and if we have that then this would seem to be less of a problem.